Add quick-verify make rule. #48842
Merged
Add quick-verify make rule. #48842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of nounset, it was impossible to run without -v.
This is useful for humans to run to catch obvious problems before pushing commits and waiting for CI to run verify checks. Quick mode only runs a whitelist of verify scripts that are reasonably fast. I set the initial bar arbitrarily at <10s each on my workstation. The whole set runs in <30s for me, assuming I had already run `make` and `hack/godep-restore.sh`. This is compared to the full `make verify` which takes [I don't know how long because I gave up after 45min].
enisoc
added
the
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
size/M
|
Test OK in my environment. |
|
cross-build is currently broken: #48887 |
|
Looks great. Thanks for this @enisoc ! /lgtm |
k8s-ci-robot
added
lgtm
|
/assign @ixdy for OWNERS review. |
|
/test pull-kubernetes-cross |
|
/lgtm nice! |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, enisoc, ixdy Associated issue requirement bypassed by: ixdy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for humans to run to catch obvious problems before
pushing commits and waiting for CI to run verify checks.
Quick mode only runs a whitelist of verify scripts that are reasonably fast.
I set the initial bar arbitrarily at <10s each on my workstation.
The whole set runs in <30s for me, assuming I had already run
makeandhack/godep-restore.sh. This is compared to the fullmake verifywhich takes [I don't know how long because I gave up after 45min].